[Fiware-developer-experience] Latest TourGuide changes

[Pablo Fernández Moniz]

Hi all!

Most of the new files are related to the FIWARE Style Guide, so we will
check all files and find with files are not currently needed for the addons.

We absolutely agree with that, one of the reasons of the big pull, is that
the actual client is completely new comparing the old one: styes and API
functionalities. We also has to readapt the code several times each time
the docker images in docker-hub stop to work for us due to new changes.

Anyway, we agree with the need to separate the pull request and we are
working on it!

Talking about other minor issues, thank you for your feedback! we will
solve them as soon as possible.

Regards,



2016-02-22 7:49 GMT+00:00 JOSE MANUEL CANTERA FONSECA <
josemanuel.canterafonseca at telefonica.com>:

> Hi,
>
> Can we separate the client  changes in different pull requests? For
> instance, look and feel changes and functional changes, but I agree that we
> should not be working by creating so big changes in one chunk … Incremental
> pull requests separating features and changes is a must …
>
> Thanks!
>
> De: <fiware-developer-experience-bounces at lists.fiware.org> on behalf of
> Alberto Martín Casado <alberto.martin at bitergia.com>
> Fecha: lunes, 22 de febrero de 2016, 8:41
> Para: "fiware-developer-experience at lists.fiware.org" <
> fiware-developer-experience at lists.fiware.org>
> Asunto: [Fiware-developer-experience] Latest TourGuide changes
>
> Hi all!
>
> During the last week we've added some changes to the TourGuide:
>
> - We've made the first integration with the CEP image. As the official CEP
> image wasn't automated in Dockerhub, we've made our own image under our
> organization, lighter and based on the Tomcat 7 official image. The
> initial approach is to generate events when temperatures exceeds some
> limits during a 30 sec period time (using the UL20 client). Documentation
> of it's usage will be added during the week.
>
> - We've added schema validators to the Restaurant, review and reservations
> entities. Now, the sever checks the elements and types before posting to
> Orion. This breaks some of the functionalities of the client, as it's using
> wrong value types (as discussed in previous e-mails).
>
> We've been also testing the client and we've found several things worth to
> mention:
>
> 1. The latest client update included >236.000 line changes and 180 files.
> As you made a pull request, I thought you would like us to review it, but
> even Github said that this was impossible (find image attached). It was an
> urgent change because the client was broken (due to the renaming), but now
> we are discussing if we should "re-write" the repository history. We
> believe that doing smaller commits allow everyone to trace all the changes
> easier (even though we are not developing the client). Also, we wonder if
> all the files included are needed (for example here:
> https://github.com/Fiware/tutorials.TourGuide-App/tree/master/client/img/FI-WARE_style_guide/wordpress).
> What do you think?
>
> 2. Initial warning. Every time we access tourguide, there's an initial
> warning that can confuse the users (image attached). It may suggest users
> that something is failing, meanwhile it's just the user needs to log in to
> start.
>
> 3. Drop-down button in reservations allow to select from [1,2,3,4,5,100].
> It should allow to generate reservations from different values (image
> attached).
>
> 4. Reservations have some typos also (image attached). Also, we've
> discussed about the field 'commensals' and it sounds a bit strange for us.
> How about 'customers' or 'diners'?
>
> Waiting for your feedback.
>
> Best!
>
> Alberto Martín
>
>
>
> ------------------------------
>
> Este mensaje y sus adjuntos se dirigen exclusivamente a su destinatario,
> puede contener información privilegiada o confidencial y es para uso
> exclusivo de la persona o entidad de destino. Si no es usted. el
> destinatario indicado, queda notificado de que la lectura, utilización,
> divulgación y/o copia sin autorización puede estar prohibida en virtud de
> la legislación vigente. Si ha recibido este mensaje por error, le rogamos
> que nos lo comunique inmediatamente por esta misma vía y proceda a su
> destrucción.
>
> The information contained in this transmission is privileged and
> confidential information intended only for the use of the individual or
> entity named above. If the reader of this message is not the intended
> recipient, you are hereby notified that any dissemination, distribution or
> copying of this communication is strictly prohibited. If you have received
> this transmission in error, do not read it. Please immediately reply to the
> sender that you have received this communication in error and then delete
> it.
>
> Esta mensagem e seus anexos se dirigem exclusivamente ao seu destinatário,
> pode conter informação privilegiada ou confidencial e é para uso exclusivo
> da pessoa ou entidade de destino. Se não é vossa senhoria o destinatário
> indicado, fica notificado de que a leitura, utilização, divulgação e/ou
> cópia sem autorização pode estar proibida em virtude da legislação vigente.
> Se recebeu esta mensagem por erro, rogamos-lhe que nos o comunique
> imediatamente por esta mesma via e proceda a sua destruição
>
> _______________________________________________
> Fiware-developer-experience mailing list
> Fiware-developer-experience at lists.fiware.org
> https://lists.fiware.org/listinfo/fiware-developer-experience
>
>


-- 

Pablo Fernández Moniz
GIT Analyst

Web <http://www.pablofm.com>    Linkedin
<http://www.linkedin.com/in/pablofernandezmoniz/>   Twitter
<http://www.twitter.com/monizpablo>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.fiware.org/private/fiware-developer-experience/attachments/20160222/d821b4f2/attachment.html>